Skip to content

Commit

Permalink
Fixed issue #8554: Hover over answer options no longer showing value
Browse files Browse the repository at this point in the history
  • Loading branch information
c-schmitz committed Jan 22, 2014
1 parent 076d51d commit f0c8fe3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion application/helpers/qanda_helper.php
Expand Up @@ -4717,7 +4717,8 @@ function do_array($ia)
{
$answer .= "\t\t\t<td class=\"answer_cell_00$ld answer-item radio-item\">\n"
. "<label class=\"hide read\" for=\"answer$myfname-$ld\">{$labelans[$thiskey]}</label>\n"
. "\t<input class=\"radio\" type=\"radio\" name=\"$myfname\" value=\"$ld\" id=\"answer$myfname-$ld\" ";
. "\t<input class=\"radio\" type=\"radio\" name=\"$myfname\" value=\"$ld\" id=\"answer$myfname-$ld\" title=\""
. HTMLEscape(strip_tags($labelans[$thiskey])).'"';
if (isset($_SESSION['survey_'.Yii::app()->getConfig('surveyID')][$myfname]) && $_SESSION['survey_'.Yii::app()->getConfig('surveyID')][$myfname] == $ld)
{
$answer .= CHECKED;
Expand Down

1 comment on commit f0c8fe3

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke answer with Expression manager ... Disallow using {if(CONDITION,"Answer 1","Answer 2")} or {if(CONDITION,'Answer 1','Answer 2')}. And if you using {QCODE} , user can see {QCODE}. The real answer is in the label. Title are not updated

I think it's better to remove the title, accessibility is fixed by the label. I remove the title due to first issue, and lable is better for RGA accessibility than a label.

Reopen the bug.

Please sign in to comment.