Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
LouisGac
committed
Jul 21, 2017
1 parent
081d467
commit f718b88
Showing
1 changed file
with
7 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f718b88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must NOT be priority : we have issue before. For public : must be survey related.
f718b88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, this fix is too much strong: some of the admin modules use url params instead of post params for language changes (like in quick translation). So I will limit it to the first page for now (but we should rather check the GET/POST logic in the different parts of the admin..).
f718b88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For public : sure must be set only according to Survey languages , or with 'allowed laguage' for other page (404/survey listing).
About admin : there are expression manager survey logic file where we need 2 different language : one for survey and survey translation (Example with min value settings) and one for admin language : see here https://github.com/LimeSurvey/LimeSurvey/blob/master/application/helpers/expressions/em_core_helper.php#L75 )