Skip to content

Commit

Permalink
Dev: Switch order of tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@olleharstedt
olleharstedt committed Jun 21, 2018
1 parent 81b024b commit fdd892f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions phpunit.xml
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<phpunit bootstrap="tests/bootstrap.php" stderr="true" >
<testsuites>
<testsuite name="Surveys">
<directory>tests/surveys</directory>
</testsuite>
<testsuite name="Questions">
<directory>tests/questions</directory>
</testsuite>
Expand All @@ -12,8 +15,5 @@
<testsuite name="Controllers">
<directory>tests/controllers</directory>
</testsuite>
<testsuite name="Surveys">
<directory>tests/surveys</directory>
</testsuite>
</testsuites>
</phpunit>

5 comments on commit fdd892f

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olleharstedt do you an idea why update order can fix issue ?

Else : great job, thanks for all of this test \o/

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LanguageChange test failed with a broken session. When putting this test first, it does not fail. So some test along the way messes with the session, or all the tests in total are too long or something. I tried to find a way to reset the session before each test but failed.

@olleharstedt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OBS: The test only failes the first time it is run. If you run the test suit two times, the second time everything is OK. A real head scratcher. :)

@olleharstedt
Copy link
Collaborator Author

@olleharstedt olleharstedt commented on fdd892f Jun 22, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really time consuming to debug since you need a new git clone and installation on every test. :|

@Shnoulle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i know :/ but really : have the alert when we have an error is really great

Please sign in to comment.