Fixed Issue #04694: File download icon in browse screen appearing always

Now, We're displaying the download icon only when the survey has a file upload question type.

git-svn-id: file:///Users/Shitiz/Downloads/lssvn/source/limesurvey_dev@9335 b72ed6b6-b9f8-46b5-92b4-906544132732

admin/admin_functions.php

@@ -96,6 +96,21 @@ function bHasSurveyPermission($iSID, $sPermission, $sCRUD, $iUID=null)
     return $aSurveyPermissionCache[$iSID][$iUID][$sPermission][$sCRUD];
 }
 
+/**
+ * Returns true if the given survey has a File Upload Question Type
+ * @param $surveyid The survey ID
+ * @return bool
+ */
+function bHasFileUploadQuestion($surveyid) {
+    $fieldmap = createFieldMap($surveyid);
+
+    foreach ($fieldmap as $field) {
+        foreach ($field as $key => $value) {
+            if ($value == "|")
+                return true;
+        }
+    }
+}
 
 /**
  * Returns true if a user has global permission for a certain action. Available permissions are

admin/browse.php

@@ -691,8 +691,10 @@
     {
         $tableheader .= "<img id='imgDeleteMarkedResponses' src='{$imagefiles}/token_delete.png' alt='".$clang->gT('Delete marked responses')."' />";
     }
-    $tableheader .="<img id='imgDownloadMarkedFiles' src='{$imagefiles}/down_all.png' alt='".$clang->gT('Download marked files')."' />"
-                  ."</td></tr></tfoot>\n\n";
+    if (bHasFileUploadQuestion($surveyid))
+        $tableheader .="<img id='imgDownloadMarkedFiles' src='{$imagefiles}/down_all.png' alt='".$clang->gT('Download marked files')."' />";
+
+    $tableheader .="</td></tr></tfoot>\n\n";
 
     $start=returnglobal('start');
     $limit=returnglobal('limit');
@@ -992,7 +994,9 @@
             $browseoutput .= " <a href='{$scriptname}?action=dataentry&amp;sid={$surveyid}&amp;subaction=edit&amp;id={$dtrow['id']}'><img src='$imagefiles/token_edit.png' alt='".$clang->gT('Edit this response')."'/></a>";
         }
 
-        $browseoutput .=" <a><img id='downloadfile_{$dtrow['id']}' src='{$imagefiles}/down.png' alt='".$clang->gT('Download all files in this response as a zip file')."' class='downloadfile'/></a>";
+        // Do not show the download image if the question doesn't contain the File Upload Question Type
+        if (bHasFileUploadQuestion($surveyid))
+            $browseoutput .=" <a><img id='downloadfile_{$dtrow['id']}' src='{$imagefiles}/down.png' alt='".$clang->gT('Download all files in this response as a zip file')."' class='downloadfile'/></a>";
 
         if (bHasSurveyPermission($surveyid,'responses','delete'))
         {