Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(codeql): fix codeql builds #2475

Closed
wants to merge 1 commit into from

Conversation

ReenigneArcher
Copy link
Member

Description

  • Try to fix macOS arm code ql build
  • Try to fix Ubuntu build by re-ordering cuda install

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.17%. Comparing base (7fb8c76) to head (90175fe).

Additional details and impacted files
@@           Coverage Diff            @@
##           nightly   #2475    +/-   ##
========================================
  Coverage     6.17%   6.17%            
========================================
  Files           86      86            
  Lines        17546   17546            
  Branches      8190    8190            
========================================
  Hits          1083    1083            
+ Misses       15410   14655   -755     
- Partials      1053    1808   +755     
Flag Coverage Δ
Linux 4.26% <ø> (ø)
Windows 2.04% <ø> (ø)
macOS-12 8.60% <ø> (+0.01%) ⬆️
macOS-13 7.83% <ø> (ø)
macOS-14 8.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci(codeql)-fix-codeql-builds branch 2 times, most recently from 5338dfb to 383ca08 Compare April 27, 2024 16:23
@ReenigneArcher
Copy link
Member Author

macOS issue: github/codeql-action#2266

Not sure about Ubuntu issue for now.

@ReenigneArcher ReenigneArcher deleted the ci(codeql)-fix-codeql-builds branch April 29, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant