Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl/handler service endpoints logic workflow abstraction #73

Open
wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

Impl/handler service endpoints logic workflow abstraction #73

wants to merge 18 commits into from

Conversation

MS-Painter
Copy link
Owner

@MS-Painter MS-Painter commented Jun 15, 2021 •
edited

Changes:

  • Cleanup server side handler service implementation using ServiceEndpoint trait abstraction.
  • Remove unneeded async constraint on Mapping stop_handler logic.
  • Remove async constraint for is_any_handler_alive logic by moving it as part of a service endpoint.
  • Improve startup_handlers iterations by iterating once.

@MS-Painter
Move is_any_handler_alive as a Server struct method
7f50289
@MS-Painter
Extract get handler (immutable) logic to Server struct
acea667
@MS-Painter
Extract type TraceHandlerStream to separate file in module
2222caf
@MS-Painter
Add basis for service endpoints submodule and outsource to it trace_h…
9f22a0f 
…andler_stream
@MS-Painter
[WIP] Extract handler service server implementations to separate endp…
85f8138 
…oints

Work in progress since currently not all endpoints can be implemented.
Will require usage of async traits which currently is not officially supported -
Could cause serious performance impacts on per function call heap allocations.
@MS-Painter
[WIP] Apply rustfmt
972eba1
@MS-Painter
[WIP] Remove async constraint for is_any_handler_alive logic by movin…
a4fd853 
…g it as part of endpoint
@MS-Painter
[WIP] cleanup endpoints instantiation with impl new
e398b62
@MS-Painter
Remove unneeded async constraint on Mapping stop_handler logic
09e7c86
@MS-Painter
Rename foldend server module to handler_server
420159a
@MS-Painter
Rename is_any_handler_alive to any_handler_alive (clippy self usage c…
9931d69 
…onvention)
@MS-Painter
Improve startup_handlers iterations by iterating once
24725e1
@MS-Painter
Fix StartHandlerEndpoint and StopHandlerEndpoint PascalCase naming
48cba66
@MS-Painter
Use iter_live_handlers in is_concurrent_handlers_limit_reached
2bb7cd3
@MS-Painter
Extract is_concurrent_handlers_limit_reached to server utils
9e0c7ee
@MS-Painter
Removed reliance on Server struct in StartHandlerEndpoint
8735555
@MS-Painter
Outsource spawn_handler_thread logic to HandlerMapping struct
86f209b
@MS-Painter
Remove unneeded comment made for spawn handler thread
de0311e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MS-Painter