Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change opening tag from canvas to div #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

a-sumo
Copy link

@a-sumo a-sumo commented Nov 26, 2022

No description provided.

@jmarcosfer
Copy link
Collaborator

Thanks for the suggestion @a-sumo.

First, please submit your PRs to the dev branch instead of master.

From what I can see we don't need to convert the canvas element into a div. Instead, the canvas element needs a closing tag and then we need a newline at L52 and correct the indentation of the closing div tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants