-
-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use redis as IMAP- and session-cache #2944
base: master
Are you sure you want to change the base?
Conversation
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
I don't want to sound obnoxious but have you tested it? What performance improvement is expected here? My take is that it can't possibly work as is since the redis container is on the "default" network which is unreachable from the "webmail" network. |
Yes, I have tested this on my live-system, but with a slightly different network setup, so your hint with default-network is helpful. My redis-cluster runs in the default network, webmail as well.
right. What is your preference? |
I personally think that documentation would be better. This is useful/required if you "scale up" the number of webmail instances... which arguably we do not support. I remain to be convinced that on a single instance deployment it significantly changes anything. |
I am interested in this as well as it will increase HA adoption |
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
tryMerge conflict. |
What type of PR?
Feature
What does this PR do?
This PR uses the already used redis-deployment for storing roundcube IMAP- and session-cache in order to speed up the Web-UI of roundcube.
Related issue(s)
Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.