skips thread safety test #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
more_core_extensions/spec/core_ext/module/cache_with_timeout_spec.rb:168:in
`block (5 levels) in <top (required)>': undefined method `thread_safety' for
test_class.thread_safety(true)
^^^^^^^^^^^^^^
from more_core_extensions/spec/core_ext/module/cache_with_timeout_spec.rb:167:in
`times'
from more_core_extensions/spec/core_ext/module/cache_with_timeout_spec.rb:167:in
`block (4 levels) in <top (required)>'
```
|
Checked commit kbrock@035eb68 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
reviewed
Feb 28, 2024
| @@ -162,6 +162,7 @@ | |||
| # and one tries to force reload, there is a small window where as it | |||
| # clears the current value, the other thread could get nil. | |||
| test_class.cache_with_timeout(:thread_safety) { 2 } | |||
| skip "thread safety not supported" unless test_class.respond_to?(:thread_safety) | |||
There was a problem hiding this comment.
I don't think we should skip the tests, but instead fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be something else going on here.
Just putting out there so we can fix