Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Iterable children parameters to h() #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theefer
Copy link

@theefer theefer commented Jun 25, 2016

Fixes #276

The issue of generic support for Iterables in all JS libraries was raised on Twitter by @leebyron and it would make it really nice to work with Immutable (among others).

Yes, it does rely on ES2015 primitives but it should fall back gracefully if used in another context.

This tentative submission adds support for Iterable lists for the children argument of h (easier than the attributes which require a map).

Feedback very much welcome on this!

PS: Hey @OliverJAsh 👋

@coveralls
Copy link

coveralls commented Jun 25, 2016

Coverage Status

Coverage increased (+0.05%) to 97.582% when pulling 75644b9 on theefer:iterable-children into 947ecf9 on Matt-Esch:master.

@OliverJAsh
Copy link

Awesome! :-)

On Sat, 25 Jun 2016, 23:35 Coveralls, notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/6753052

Coverage increased (+0.05%) to 97.582% when pulling 75644b9
75644b9
on theefer:iterable-children
into 947ecf9
947ecf9
on Matt-Esch:master
.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#400 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AA4QCc1gJ9faOrCajFYXQB9O9MdD2BElks5qPa02gaJpZM4I-cVE
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants