fix: add missing dependency @vue/shared #520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
/src/add-routes-tracker.js
there's an import from@vue/shared
, which is not listed in the dependencies. This happens to work in many cases, since the dependency is used by many other vue-packages. But not reliably.In our project we were unlucky enough to not have
@vue/shared
in the top-level node-modules after runningnpm prune --omit=dev
, we only had it nested under other packages (since they didn't share the same version). This caused aMODULE_NOT_FOUND
exception from node when we tried to loadvue-gtag
. Funnily enough it only happened in production - since the devs never pruned their packages.I checked if there were any other missing dependencies, but could not find any.
npx depcheck
agrees that this is the only missing dependency.Another possible solution is to remove the import and just define
const isFunction = (val) => val is Function
on your own.