Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many improvements to AutoSign #4594

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

RealMuffinTime
Copy link
Contributor

@RealMuffinTime RealMuffinTime commented May 21, 2024

Type of change

  • New feature

Description

  • Remove hardcoded time placeholder from MeteorStarscript.java
  • Added persistent settings to save sign lines to
  • Added Starscript support
  • Added possibility to also apply back side of sign
  • Added possibility to overwrite or keep existent text on sign
    When not applying anything, open edit screen normally

How Has This Been Tested?

  • Placing many signs, in diffrent situations
  • On a local vanilla server.
  • Some SMP servers.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@RacoonDog
Copy link
Contributor

what was wrong with the time placeholder? it looks correct from looking at the code

@RealMuffinTime
Copy link
Contributor Author

It was not wrong, but it did always overwrite the time placeholder from the Starscript StandardLib.timeFormat object.

@RacoonDog
Copy link
Contributor

It was not wrong, but it did always overwrite the time placeholder from the Starscript StandardLib.timeFormat object.

ahh i see

(in hope for starscript date and timezone formating)
@RealMuffinTime
Copy link
Contributor Author

While testing I found some bigger issues, need to look into how to solve these.

@RacoonDog
Copy link
Contributor

While testing I found some bigger issues, need to look into how to solve these.

what are the issues?

@RealMuffinTime
Copy link
Contributor Author

First something unrelated: sign.getEditor() is always null for me?

So the module works fine on a server which accepts sign editing (vanilla).
But I also tested it on servers where editing is not possible, this turned out to have negative side effects, while having back sign writing enabled. Double placed signs on 2b2t (2b2t doesn't allow editing), every second sign empty on constantiam (older mc version).

@RealMuffinTime
Copy link
Contributor Author

I tried to use sign.getEditor() to verify if the BlockInteraction was successfull and if the sign could be edited.

add warning if server does not support sign edit
@RealMuffinTime
Copy link
Contributor Author

Is checked and tested. Added a warning, if server doesn't support back sign editing.

@RealMuffinTime RealMuffinTime marked this pull request as ready for review May 31, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants