Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taper command finalised #1034

Merged
merged 5 commits into from Nov 4, 2021
Merged

Taper command finalised #1034

merged 5 commits into from Nov 4, 2021

Conversation

ghislain-roy
Copy link
Contributor

Please review the code and documentation.
Tests have been updated with a full fledged test-taper that includes the tapering=true for Twiss and Match. The test-tapering test has been removed.

@tpersson
Copy link
Contributor

Thanks! Could you just resolve the conflicts? Then the automatic testing here should be able to run as well.

@tpersson
Copy link
Contributor

There seems to be some warnings on some of the platforms. It is a bit strange since I cannot see it when I compile it locally but if you for example see this run

https://github.com/MethodicalAcceleratorDesign/MAD-X/pull/1034/checks?check_run_id=3906911740

I am not sure if the warnings real or some problem with the setup here in GitHub but would be good to check.

@ghislain-roy
Copy link
Contributor Author

ghislain-roy commented Oct 18, 2021

Hello,

I am not sure if the warnings real or some problem with the setup here in GitHub but would be good to check.

All but two of the failures in checks are due to missing docker units to run the tests. The last two failures are due to a missing input module file that should have been compiled together with the rest. Could that be a case of missing "make clean" before the actual make.

I also noticed that some tests are run on "make tests" instead of "make tests-all" "testwhich means we are missing the "tests-long" of which "test-taper" is a part.

I am afraid there is not much more I can do with this now. Up to you !
Cheers,
Ghislain

@tpersson tpersson merged commit a6a2db0 into MethodicalAcceleratorDesign:master Nov 4, 2021
@tpersson
Copy link
Contributor

tpersson commented Nov 4, 2021

Thanks! It is now merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants