BEAM sanity checks

[kyrsjo]

Catch some problematic beam statements and emit warnings/fatal_error as appropriate and consistent with the rest of the file. Typos happen, and they are not always obvious; it is nice when the program detect a problem when it occurs and not later.

I think I kept to the style of the file, even fixed a formatting mistake another place in the file.

[madcern]

I think this is a good idea to catch error in the input. We would however, need to update many tests (I should have a script that does it). I will just check with Laurent before I do the update.

[kyrsjo]

Great, thanks! I don't know how to see the actual output of the individual tests, is it that it is actually catching problematic input files, spitting out warnings? Or is it even catching pc < 0?

[tpersson]

Some of them are simply the warning which then changes the output put some are more serious. To see the results from the test you have to make numdiff and then simply make tests-all (or have a look at the Travis build.

[kyrsjo]

Hi, thanks! By gleaming at the Travis output I figured out how to run the test suite. It seems that the issue is that I get an overspecification warning from the beam command at the very beginning of the output, and this throws off the rest of the test:

$ ../../madx-linux64-gnu test-table.madx 
++++++ warning: Both energy and pc specified; pc was ignored.
++++++ warning: Both energy and gamma specified; gamma was ignored.
++++++ warning: Both energy and beta specified; beta was ignored.
++++++ warning: Both energy and bhro specified; brho was ignored.

  ++++++++++++++++++++++++++++++++++++++++++++
  +     MAD-X 5.04.02  (64 bit, Linux)       +
  + Support: mad@cern.ch, http://cern.ch/mad +
  + Release   date: 2018.10.03               +
  + Execution date: 2018.10.30 15:21:49      +
  ++++++++++++++++++++++++++++++++++++++++++++
Option, -info; // avoid redefinition info

This bogus warning of course has to be avoided... Time for some digging!

[coveralls]

Coverage increased (+0.02%) to 53.836% when pulling b67a7d6 on kyrsjo:beam-warnings into 97e8d8c on MethodicalAcceleratorDesign:master.

[kyrsjo]

OK, that fixed all the bugs - some in the code (initialization) and some in the test test-sequence-3.

What remains seems to just be coveralls - but I can add a new test to purposely trigger the warnings?

[tpersson]

Excellent! Also very nice with a test!

[kyrsjo]

Yeah, I figured out that there was already a relevant test so I just added it to that.

Thanks for merging!