Added support for thick RBEND in TRACK #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alatina
changed the title
ldeniau
requested changes
Nov 16, 2018
|
Hi Laurent, OK I will add an example, hopefully next week (from Japan). Anyway I think you can accept the pull request already: RBENDs and SBENDs are basically the same elements, with a different definition for the entrance and exit angles E1 and E2, which I have implemented the same way it is done in TWISS. It was a very simple modification. |
|
Hi Laurent, I added a test for the THICK tracking in the RBEND. This should close this thread and let you accept this pull request.. |
ldeniau
approved these changes
Dec 18, 2018
|
Right. Then I think we can close #704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.