Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update based on changes from derived class #733

Merged
merged 6 commits into from Feb 20, 2019

Conversation

tpersson
Copy link
Contributor

This PR does two things:

  1. Adds the option (OPTION, update_from_parent) which changes the behavior of the update an element. If the option is enabled any element derived from another class will also be updated in case the parent class is changed. This feature was requested by the FCC study.
  2. Adds a warning in case you define a multipole with non-zero length.

@tpersson
Copy link
Contributor Author

This fixes the issues #731 and #723.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 54.249% when pulling 4450637 on tpersson:update_parent into d2684a2 on MethodicalAcceleratorDesign:master.

@madcern
Copy link
Contributor

madcern commented Feb 20, 2019

This PR does not change any default behavior and is therefore rather safe.

@madcern madcern closed this Feb 20, 2019
@madcern madcern reopened this Feb 20, 2019
@madcern madcern merged commit dd3ce8c into MethodicalAcceleratorDesign:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants