Generalized thin combine function (don't merge) #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the status? Can you reproduce the results of the previous implementation, available from Frank here: http://frs.web.cern.ch/frs/Source/madX_SC/src/trrun.f90 |
|
Malte will make some test and make comparison with the previous implementation and thick elements. |
madcern
approved these changes
Oct 21, 2019
|
@rdemaria I have compare the results and I get the same results (some small numerical differences) for an easy tracking and for the twiss I compare with the PS lattice. The numerical difference is not surprising considering it uses a different formalism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is following Mate's approach but still gives strange results that needs to be checked in detail.
This is just to discuss so don't merge