Chrom command gives chromaicity in PT + fix of weak focusing in TWISS #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: do you pass angle and k0 to PTC separately? This is to check if the case of angle!=k0l is managed well by PTC |
|
No the angle is not transferred to PTC. I had a look since tI wanted to have the tapered lattice also in PTC. I think it should be quick to fix, since it is effectively the same thing as an error . |
|
I think it is important also for the sake of making comparisons.. |
|
I agree. I thought it was taken care of when this was implemented but I guess it was forgotten.. |
madcern
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.