Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrade-aks-cluster.md #122056

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ramdaspotale
Copy link

Update upgrade-aks-cluster.md to fix --drain-timeout parameter on az aks nodepool update.

according to https://learn.microsoft.com/en-us/cli/azure/aks/nodepool?view=azure-cli-latest#az-aks-nodepool-update and also from my experience correct parameter to set drain timeout is --drain-timeout and not --drainTimeoutInMinutes.

Update upgrade-aks-cluster.md to fix --drain-timeout parameter on az aks nodepool update. 

according to https://learn.microsoft.com/en-us/cli/azure/aks/nodepool?view=azure-cli-latest#az-aks-nodepool-update and also from my experience correct parameter to set drain timeout is --drain-timeout and not --drainTimeoutInMinutes.
Copy link
Contributor

@ramdaspotale : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 85fdbab:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/upgrade-aks-cluster.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ramdaspotale
Copy link
Author

Hey @schaffererin Can you please approve this PR?

Copy link
Contributor

Learn Build status updates of commit 9d4b5d0:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/upgrade-aks-cluster.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Apr 29, 2024

@schaffererin

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants