Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar + typo fix #1004

Merged
merged 2 commits into from Oct 27, 2023
Merged

Grammar + typo fix #1004

merged 2 commits into from Oct 27, 2023

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Aug 9, 2023

Contributes to #1003

@mairaw mairaw requested a review from a team as a code owner August 9, 2023 18:30
wadepickett
wadepickett approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor suggestion on description meta data.

@mairaw @wadepickett
Update iis/extensions/url-rewrite-module/modifying-http-response-head…
d472c0e 
…ers.md

Co-authored-by: Wade Pickett <wpickett@microsoft.com>
@mairaw
Copy link
Contributor Author

mairaw commented Aug 11, 2023

I still have some questions about step 4 here
image

based on the screenshot, it's probably another typo

@wadepickett
Copy link
Contributor

I'm not up on this and I am afraid I don't know. It could have been a product change over time that is not reflected.

@mairaw
Copy link
Contributor Author

mairaw commented Aug 14, 2023

No worries, maybe something that @mertozturk80 or @John-Hart could help answer.

@Rick-Anderson
Copy link
Contributor

@John-Hart quick question please

@wadepickett
Copy link
Contributor

@John-Hart, see Maira's quick question above.

@John-Hart
Copy link
Contributor

@sujitnayak can you look into Maira's quick question above about step 4?

@sujitnayak
Copy link

Yes it should be ORIGINAL_HOST.

@Rick-Anderson Rick-Anderson merged commit d5e5965 into main Oct 27, 2023
2 checks passed
@Rick-Anderson Rick-Anderson deleted the mairaw-patch-1 branch October 27, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadepickett wadepickett wadepickett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@mairaw @wadepickett @Rick-Anderson @John-Hart @sujitnayak