Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete contents related to URLScan #1016

Merged
merged 2 commits into from Feb 26, 2024

Conversation

lextm
Copy link
Contributor

@lextm lextm commented Oct 30, 2023

#403 and #418 showed that users might still be confused about URLScan.

This pull requests remove all related articles and unnecessary references.

@lextm lextm requested a review from a team as a code owner October 30, 2023 19:30
@lextm
Copy link
Contributor Author

lextm commented Oct 30, 2023

@Rick-Anderson you might review and approve this.

I tried to remove the articles and references instead of adding notes to them saying they are obsolete, because the installers of URLScan were removed from Microsoft sites and new users on IIS 10 should not be able to install them any more.

Not sure if this is the right approach for obsolete contents.

@lextm lextm changed the title Removed obsolete contents. Removed obsolete contents related to URLScan Oct 31, 2023
@tdykstra
Copy link
Collaborator

@lextm can you please resolve the merge conflicts that resulted from merging PR #1015?

@lextm
Copy link
Contributor Author

lextm commented Feb 26, 2024

Sure. I will work on it soon.

@lextm
Copy link
Contributor Author

lextm commented Feb 26, 2024

@tdykstra Done. You can start review now.

Copy link
Collaborator

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdykstra tdykstra merged commit 4689e73 into MicrosoftDocs:main Feb 26, 2024
2 checks passed
@lextm lextm deleted the retire-urlscan branch March 1, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants