New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement progress bar and update progress indicators #414
base: main
Are you sure you want to change the base?
Conversation
@@ -167,7 +167,7 @@ struct GenerationConfig: Sendable, Identifiable { | |||
return models | |||
} | |||
|
|||
func loadPipeline( | |||
func preparePipeline( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found a more elegant way to handle this. Issue is that when load pipeline finished and generation of image is about to start, there's a short time while generator returns back to ready state, which makes UI flicker.
@@ -77,7 +77,6 @@ struct GalleryItemView: View { | |||
Image(image, scale: 1, label: Text(verbatim: String(sdi.seed))) | |||
.resizable() | |||
.aspectRatio(contentMode: .fit) | |||
.padding(4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's better, but feels like this gap was unnecessary, I can revert it.
bf0ba8b
to
77bc00f
Compare
|
@gdbing Thanks for looking into this!
Items start to hide from right to left behind
Yeah, good point, I'll see what I can do, maybe reorganizing it a little bit. The point is I wanted to provide info about current progress right in the new progress block, but the whole queue (and maybe more detailed) information would be hidden in the popup. I think this |
Some improvements for UI around progress indicators.
Now there are no overlays over the preview image, and it's easier to stop generation, since stop button is right in the toolbar.
I don't have much Swift experience, will be glad for any hints or fix suggestions.
Screen.Recording.2024-03-13.at.23.28.45-1.mov