New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
background-clip:text probably needs a new test #199
Comments
There should be, but it will have to be a separate, non-included test (for now) because background-clip: text is not a real value in the CSS Borders & Backgrounds spec (as of CR/15Feb2011). Theoretically, what this test would do is the same as the regular background-clip test, but set explicitly with a value of "text", and then do a boolean verify that the return value still contains "text". Won’t be as fast as the standards-based background-clip test though. |
adam, do you want to take a crack at adapting the above test to setting and retrieving the style prop? |
Will do. I'll provide or new test or post back if I get stuck. |
Thanks for the help, all. Would you please verify the test below? In addition, I'm much, much stronger on the CSS end than JS, so I'd appreciate a kind smack upside the head if there's a better way to do this. :) This returns true in the appropriate browsers for me:
|
adam, this is the style that you want: #137 but it's written as a modernizr patch and not a plugin.. so that changes things. |
wrote it finally! |
It seem that it doesn't work well for IE 8. div.style.cssText = "background-clip:text;-webkit-background-clip:text;-moz-background-clip:text;-o-background-clip:text;-ms-background-clip:text;-khtml-background-clip:text;" IE does seem to clean 'cssText' after assignation. I haven't test the others versions. |
Return a false positive for Opera 11.61 |
ruh roh. should we file a ticket against them? |
I do not know much about [HTMLElement].style.cssText behavior. I've tried this: Modernizr.testStyles(' #modernizr { '+ Modernizr._prefixes.join('background-clip: text; ') +' } ', function(elem, rule){ Modernizr.addTest('backgroundcliptext', ( window.getComputedStyle ? getComputedStyle(elem, null).getPropertyValue('background-clip') : elem.currentStyle['background-clip'] ) == 'text'); }); Seem to work well for Webkit, FF and Opera but IE I've not yet had the opportunity to use the other "background options" dectection features (like background-size: cover;) but, is it possible that the tests also return a false positive with IE ? Rapidly I quickly test Gist for my test: |
I am running into this too: Webkit doesn't say it supports it, but it clearly does (it's on the page). Seems buggy. |
The test appears to be returning a false positive in IE 9. |
I've just removed the test from the repo. This'll kill it from the builder (soon) too. For now, no test exists that is reliable. I'm happy if someone can find another one. |
Just today I had an epiphany and wrote on how you can fallback within CSS for |
Nice technique of using |
I think i found a reliable test method, see #925 I tested it in Chrome, Firefox, Safari, Opera, iOS and IE6 - IE10 |
Resolved by #925. |
…it. Needs a better test. Ref Modernizr#199
This test is giving a false positive in Microsoft Edge. |
@fraserpage - Edge actually does support it, but with a -webkit- prefix, for compatibility. |
Interesting. Thanks @phistuck |
🤔 |
Thanks for this test for background-clip:text. Unfortunately—it doesn't appear to work in Firefox 4.
Is there any way to detect specifically for "background-clip:text" instead of simply "background-clip"?
The text was updated successfully, but these errors were encountered: