Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert kebab-case to camelCase in testProps for browsers that don't have @supports support #1323

Merged
merged 3 commits into from May 21, 2014

Conversation

patrickkettner
Copy link
Member

fixes #1322

@stucox
Copy link
Member

stucox commented May 21, 2014

Turns out this fix had the knock-on effect of enabling testProp() and testAllProps() to accept kebab-case too – which is nice.

Tests are failing because it appears we had an explicit test to verify that kebab-case isn’t supported:

  // test/js/unit.js:L413
  equal(false, Modernizr.testProp('font-size'), 'Nobody supports font-size');

  // test/js/unit.js:L440
  equal(false, Modernizr.testAllProps('font-size'), 'Nobody supports font-size');

I’ve raise a PR against your branch to update the tests and the comments at the top of the relevant files in src/. Have also (slightly prematurely) updated the release notes.

@stucox stucox added this to the Modernizr v3 milestone May 21, 2014
`testProp()` and `testAllProps()` now accept kebab-case – updating tests...
stucox pushed a commit that referenced this pull request May 21, 2014
convert kebab-case to camelCase in testProps for browsers that don't have @supports support
@stucox stucox merged commit 4defc95 into Modernizr:master May 21, 2014
@stucox
Copy link
Member

stucox commented May 21, 2014

Cheers bro!

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this pull request Feb 22, 2015
convert kebab-case to camelCase in testProps for browsers that don't have @supports support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kebab-case syntax for testAllProps() doesn’t work in iOS / Safari
2 participants