Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new setting AllowConnFromSubnets #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ijc
Copy link
Contributor

@ijc ijc commented Mar 14, 2021

This is a fine grained version of AllowConnFromAll which allows configuration
of specific subnets or hosts.

Checklist

This is a fine grained version of `AllowConnFromAll` which allows configuration
of specific subnets or hosts.
@ijc
Copy link
Contributor Author

ijc commented Mar 14, 2021

I was unsure where to document this, I don't find the existing AllowConnFromAll anywhere in the wiki and the google hits are all the code & the original trac ticket https://code.mythtv.org/trac/ticket/13024 that added it.

@bennettpeter
Copy link
Member

@ijc
Copy link
Contributor Author

ijc commented Mar 14, 2021

@bennettpeter thanks, I failed to find it because it doesn't mention the db name, which now I think of it makes perfect sense since that's really an internal detail.

I'm just about to turn in for the night so I'll propose some words for the wiki here later.

@garybuhrmaster
Copy link
Contributor

As I recall, QHostAddress::parseSubnet did not support IPv6 addresses. Has that been fixed in Qt?

@garybuhrmaster
Copy link
Contributor

As I recall, QHostAddress::parseSubnet did not support IPv6 addresses. Has that been fixed in Qt?

Never mind, I found my own answer, it has been fixed for IPv6 (later than I would have liked, which should have happened over a decade ago).

@stuarta
Copy link
Member

stuarta commented Mar 15, 2021

@ijc Can you raise an issue describing what the issue is that this is resolving please?

@ijc
Copy link
Contributor Author

ijc commented Mar 15, 2021

@stuarta done, please see #339.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More fine grained control over client IPs allowed to connect to backend
4 participants