Manual Recordings: add optional UI element to set subtitle #646
+128
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For earlier versions of MythTV, the theme changes for other themes will result in a textedit widget that does not effect the resultant recording rule, which may be confusing. However, this is still technically backwards compatible. |
ulmus-scott
force-pushed
the
manual_recordings_subtitle
branch
from
f4375a6
to
3de0280
Compare
If the element is absent, the behavior is unchanged.
Move "title" up slightly and squeeze in "subtitle", moving the rest down slightly, except "duration", which I moved up slightly to make the spacing more even.
Move "title" up and squeeze in "subtitle", moving the rest down slightly, except "duration", which I didn't move to make the spacing more even.
Move "title" up and squeeze in "subtitle", moving the rest down slightly, except "duration", which I didn't move to make the spacing more even.
Move "title" up and squeeze in "subtitle", moving the rest down slightly, except "duration", which I didn't move to make the spacing more even.
Move "title" up and squeeze in "subtitle", moving the rest down slightly, except "duration", which I didn't move to make the spacing more even.
so it doesn't encroach on the new position of "title" and "titlelabel". The position was copied from MythCenter-wide. MythCenter and default use the slightly different position of 20,5 instead.
ulmus-scott
force-pushed
the
manual_recordings_subtitle
branch
from
3de0280
to
0fe1c3c
Compare
|
The same change should be made in the web app. The web app has all the capabilities of the frontend for scheduling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the element is absent, the behavior is unchanged.
I don't know how to test default and default-wide, but the changes are identical to the other themes.
Should this also bump the theme minor versions?
Checklist