metadata/Music: upgrade to unmodified CU LRC lyrics grabbers #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
except for files not needed: resources/, addon.xml, default,py and README.txt. MythMusic uses only the LyricsFetchers in lib/culrcscrapers/*/lyricsScraper.py
by moving our CLI from *.py to common/culrcwrap.py which uses tiny Kodistubs to let the few xbmc calls work. See README for simple upgrade procedure for any future CU LRC upgrades.
|
While this diff adds more lines than it removes, over 1500 add lines are in imported changelog and LICENCE and lib/broken-scrapers that are not used. Code in use drops from 2900 lines to 2357 lines for 543 less lines as measured by And 1677 of those 2357 lines are in lib maintained by CU LRC, leaving < 700 lines that we maintain, all small and easy in ./, common/ and Kodistubs/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #845, fixes #427.
CU LRC is used unmodified and can be easily upgraded at any time, see README.
There are 14 working grabbers that pass their tests via common/testall.py or the better ./testlyrics.pl -t -k
The first commit is CU LRC imported with zero changes other than discarding unneeded files.
The second commit is the changes to our files to use the import. For each of our *.py, the CLI moved to common/culrcwrap.py while the grabber moved to the source location lib/culrcscrapers/*/*.py leaving a simple metadata header per scraper.
Kodistubs is ~100 lines that lets the few xbmc calls work.
Checklist