Evaluate lazily Android specific global values #2002
Conversation
jasssonpet
changed the title
| @@ -31,7 +32,7 @@ export function _clearForwardTransitions(fragment: any): void { | |||
| fragment[EXIT_POPENTER_TRANSITION] = undefined; | |||
| } | |||
|
|
|||
| if (_sdkVersion >= 21) { | |||
| if (_sdkVersion() >= 21) { | |||
There was a problem hiding this comment.
error TS2365: Operator '>=' cannot be applied to types '() => number' and 'number'.
There was a problem hiding this comment.
I'll take a look. It's compiling fine on my machine, though.
There was a problem hiding this comment.
@enchev This is fixed now.
|
Sounds very neat. |
jasssonpet
force-pushed
the
jasssonpet/lazy-snapshot
branch
from
b7cb330
to
3a3bbea
Compare
jasssonpet
force-pushed
the
jasssonpet/lazy-snapshot
branch
from
3a3bbea
to
68b65ce
Compare
|
👍 |
2 similar comments
|
👍 |
|
👍 |
| let _value: T; | ||
| return () => _value || (_value = action()); | ||
| })(); | ||
| } |
There was a problem hiding this comment.
Can't we reuse the outer scope :D
export default function lazy<T>(action: () => T): () => T {
let cache: T;
return () => cache || (cache = action());
}There was a problem hiding this comment.
@PanayotCankov Yeah, the self-executing function is redundant.
|
A premature optimization on my end - maybe we can move the 👍 |
jasssonpet
force-pushed
the
jasssonpet/lazy-snapshot
branch
from
68b65ce
to
02df926
Compare
|
@hdeshev I like your suggestion, but let's push forward the webpack plugin. It will resolve such issues. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Related to: #1563
ping @atanasovg, @KristinaKoeva