New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add very high and very low #2656
base: master
Are you sure you want to change the base?
Conversation
Imagine two individuals with identical average glucose, identical time in range, identical percent low and identical percent high. But imagine if one of the two has lows that only go as low as 65mg/dL while the other's lows often go as low as 45mg/dL. I personally would like to have a record of my very low statistics and see how I can reduce that hopefully to 0. Please let me know what you think and if I need to make any changes to address anything that I may have not considered. Thanks |
1- You may wonder why I have rotated the top portion of the page. I didn't want to. At first, I wanted to add the two new parameters to the 3 existing ones on the first line. Doing that would make the line too long for the portrait mode. xDrip is used in portrait mode by many. I rotated the top portion of the page. This allows us to add two more parameters, and also to show the corresponding parameters as well as the result for each line and still have lines shorter than some of the original lines. 2- Why I have removed absolute numbers. Ideally, you will be 100% in range. If not, it is good to know what the percentages are so that you can improve them and be able to see from month to month how much you have been able to improve. It is important to know what the total number is. If you don't have enough readings, your statistics will not have valid representation. So, that's why I have added the total number, which is currently missing in the presented values. |
Why I have reduced the font size. If you look at all pages in xDrip, you see very large fonts used on the statistics page. Other than the main glucose value shown on the main screen, I believe the largest font is used on the statistics page. |
I'm happy to create a new page just for reports if the reason this PR does not even have a review is that we don't want to change the existing page. If people are not using xDrip for generating reports, why not allow minor changes to the page? |
We currently show the absolute numbers for in-range, low and high. But, we don't show the absolute total number of readings. If you think about what the three provided percentages are, those are percentages with respect to the total number of readings. But, we don't even show what that is. This PR adds the total number of readings to the page. Everything else, all the shown percentages, is with respect to it. |
I'm concerned about the increase in complexity that this would give and the change to the user interface in how the statistics would be presented. Overall I think it can be good to include a very low percentage but I'm not sure about this implementation. For example what have you done on the chart screen? I think there maybe should be a consideration for revamp of statistics page but also to make it easier to understand, for example with a simple bar showing the percentages with the numbers and thresholds next to it. Possibly to replace the pie chart screen and be shown as the first page with more detailed table of statistics on the second page. I'm thinking the very low value should have a default value which only a very few users will want to change and we can place that behind an advanced settings page to avoid cluttering the high/low preference page as is. Very high is potentially more difficult to incorporate in a user interface but we could put it at some value like that at which glucose would be ejected by kidneys and then use some logic to bump this up if the user sets their high level above this and likewise put it in an advanced settings page. |
My doctor asked me "why don't you use Clarity". |
I am more than happy to provide detail guides for everything on the statistics page to clarify any possible confusion. |
I will change the pie chart page as you have suggested. The user and their medical team should be able to adjust very high and very low values the same way they can adjust low and high values. The persistent high and forecast low alerts should use trigger values independent of the statistics high and low. |
Any plans on reviewing this? |
@ibrodezk This was reviewed a long time ago and I have been given directions/options to improve. |
Oh great didnt understand that, guessing discussions arent being done on the PR, sorry for the noise. |
No, this is the only feedback I have had with respect to this: #2656 (comment) |
But, there is another PR about adding capture rate to the statistics page. I would like to add a settings page dedicated to statistics that would allow user to choose what parameters to be included on the distribution page. And I have not got an objection to that. I have assigned all of these to myself. |
Other apps offer very high and very low.
I have changed the format to allow the addition of the two new parameters without making the lines too long for portrait mode.
I have reduced the font size hoping that languages that result in longer text will not wrap.
fixes: #579
This is tested on Android 8 and a very small screen virtual device Android 11.