Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add very high and very low #2656

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Feb 1, 2023

Before After
Screenshot_20230201-114656 Screenshot_20230201-112853
Screenshot_20230201-114718 Screenshot_20230201-113239

Other apps offer very high and very low.
I have changed the format to allow the addition of the two new parameters without making the lines too long for portrait mode.
I have reduced the font size hoping that languages that result in longer text will not wrap.

fixes: #579

This is tested on Android 8 and a very small screen virtual device Android 11.

@Navid200
Copy link
Collaborator Author

Imagine two individuals with identical average glucose, identical time in range, identical percent low and identical percent high.
Their xDrip statistics page will be identical.

But imagine if one of the two has lows that only go as low as 65mg/dL while the other's lows often go as low as 45mg/dL.
It is very useful to be able to see that. That is why there are apps, like Clarity, that have two additional parameters, very low and very high, used for statistics.

I personally would like to have a record of my very low statistics and see how I can reduce that hopefully to 0.
But, xDrip does not have those two parameters.
This PR adds them.

Please let me know what you think and if I need to make any changes to address anything that I may have not considered.

Thanks

@Navid200
Copy link
Collaborator Author

1- You may wonder why I have rotated the top portion of the page. I didn't want to.

At first, I wanted to add the two new parameters to the 3 existing ones on the first line. Doing that would make the line too long for the portrait mode. xDrip is used in portrait mode by many.
Placing the 5 parameters on the same line would be useful in landscape.

I rotated the top portion of the page. This allows us to add two more parameters, and also to show the corresponding parameters as well as the result for each line and still have lines shorter than some of the original lines.

2- Why I have removed absolute numbers.
We currently show percentages. And we also show absolute numbers. Those are redundant.
If we tell user how many total readings they have and what percentage of that total is in range and what percentage of that total is low and what percentage of that total is high, the user has everything matters. There is no value in having the corresponding numbers. Those can be easily calculated if needed.

Ideally, you will be 100% in range. If not, it is good to know what the percentages are so that you can improve them and be able to see from month to month how much you have been able to improve.
But, there is no value in knowing what the corresponding number is.

It is important to know what the total number is. If you don't have enough readings, your statistics will not have valid representation. So, that's why I have added the total number, which is currently missing in the presented values.

@Navid200
Copy link
Collaborator Author

Why I have reduced the font size.

If you look at all pages in xDrip, you see very large fonts used on the statistics page. Other than the main glucose value shown on the main screen, I believe the largest font is used on the statistics page.
There are fonts much smaller used on many other pages in xDrip. So, the medium font I have used is not very small.
If I use the large font as it was before, the in-range line may become too long for some small devices.

@Navid200 Navid200 requested a review from jamorham March 2, 2023 17:05
@Navid200
Copy link
Collaborator Author

Navid200 commented Mar 3, 2023

I'm happy to create a new page just for reports if the reason this PR does not even have a review is that we don't want to change the existing page.
The current xDrip statistics page is missing those items (very high and very low).

If people are not using xDrip for generating reports, why not allow minor changes to the page?
If people are using xDrip for creating reports, this PR brings in data that other apps that some use for reports already include.
So, this is an improvement to user experience either way without causing confusion.

@Navid200
Copy link
Collaborator Author

We currently show the absolute numbers for in-range, low and high. But, we don't show the absolute total number of readings.

If you think about what the three provided percentages are, those are percentages with respect to the total number of readings. But, we don't even show what that is.
Currently, one has to add the three absolute values to calculate the total.

This PR adds the total number of readings to the page. Everything else, all the shown percentages, is with respect to it.
So, the page becomes complete and is clear of redundant data.

@jamorham
Copy link
Collaborator

I'm concerned about the increase in complexity that this would give and the change to the user interface in how the statistics would be presented.

Overall I think it can be good to include a very low percentage but I'm not sure about this implementation. For example what have you done on the chart screen?

I think there maybe should be a consideration for revamp of statistics page but also to make it easier to understand, for example with a simple bar showing the percentages with the numbers and thresholds next to it. Possibly to replace the pie chart screen and be shown as the first page with more detailed table of statistics on the second page.

I'm thinking the very low value should have a default value which only a very few users will want to change and we can place that behind an advanced settings page to avoid cluttering the high/low preference page as is. Very high is potentially more difficult to incorporate in a user interface but we could put it at some value like that at which glucose would be ejected by kidneys and then use some logic to bump this up if the user sets their high level above this and likewise put it in an advanced settings page.

@Navid200
Copy link
Collaborator Author

Navid200 commented Apr 28, 2023

Thanks for the review.

Very High and Very Low are shown by Clarity. They are considered to be a standard now.
There are many users who are already exposed to all of that using Clarity.
I did not add these to start from scratch. I added them because it is like we are falling behind.

You ask what I have done on the charts. I don't understand the question.
Very low is a subset of low. And very high is a subset of high. Therefore, there is no need to change anything on the chart.
Neither does Clarity. The Clarity AGP does not show very low or very high.
Screenshot 2023-04-28 073951

@Navid200
Copy link
Collaborator Author

Navid200 commented Apr 28, 2023

My doctor asked me "why don't you use Clarity".
My response was that I could provide any report she needed with the tool I use.
I don't believe in that response any longer.
I would like xDrip to live up to that statement. I don't want to reinvent the wheel. We are currently lacking very low and very high percentages.

@Navid200
Copy link
Collaborator Author

I am more than happy to provide detail guides for everything on the statistics page to clarify any possible confusion.

@Navid200
Copy link
Collaborator Author

I will change the pie chart page as you have suggested.

The user and their medical team should be able to adjust very high and very low values the same way they can adjust low and high values.

The persistent high and forecast low alerts should use trigger values independent of the statistics high and low.

@Navid200 Navid200 marked this pull request as draft April 28, 2023 19:35
@ibrodezk
Copy link

ibrodezk commented Oct 2, 2023

Any plans on reviewing this?

@Navid200
Copy link
Collaborator Author

Navid200 commented Oct 2, 2023

@ibrodezk This was reviewed a long time ago and I have been given directions/options to improve.
Unfortunately, I have a lot I have to do and it takes time. I am sorry.
This will definitely be done. I am sorry I cannot promise when.

@ibrodezk
Copy link

ibrodezk commented Oct 2, 2023

Oh great didnt understand that, guessing discussions arent being done on the PR, sorry for the noise.

@Navid200
Copy link
Collaborator Author

Navid200 commented Oct 2, 2023

No, this is the only feedback I have had with respect to this: #2656 (comment)

@Navid200
Copy link
Collaborator Author

Navid200 commented Oct 2, 2023

But, there is another PR about adding capture rate to the statistics page. I would like to add a settings page dedicated to statistics that would allow user to choose what parameters to be included on the distribution page. And I have not got an objection to that.
So, my plan has been to add that settings page first.
Then, we can add very low and very high. But, not everyone will need to see those and we can remove those two from the defaults.
So, those who want very low and very high can have them and those who don't, don't have to see them.

I have assigned all of these to myself.
Unfortunately, we don't have many developers who are actively working on these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serious Low
3 participants