Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Silent mode vs Do not disturb #2799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fwolter
Copy link
Contributor

@fwolter fwolter commented Apr 23, 2023

I had a deep dive why Other alerts/"Override Silent mode on these alerts" isn't working on my phone. Turns out the setting is only referring to the Do not disturb function.

This PR changes the text from "Override Silent mode on these alerts" to "Ignore Do not disturb" for the following reasons:

  • The option has no effect when the phone's volume is 0 (I'd call that silent). Alarms won't come through if you set the tristate sound/vibrate/no sound button in the pull down menu to no sound. This is a different behavior to the glucose alerts. They do override the no sound setting. The renaming helps the user to differentiate between the behaviors and prevents confusion like here Missed Readings override silent #193 (comment)
  • The suggested wording is compatible with the Android settings. See screenshot below.
  • The current text doesn't fit onto the screen of a Galaxy S8+. See screenshot below.

It also adds a summary to the setting, explaining that it has no effect when using Notification Channels.

I tested the behavior with and without Notification Channels.

Old:
grafik

New:
grafik

Android wording:
grafik

@Navid200
Copy link
Collaborator

Navid200 commented Apr 23, 2023

Please note that I had a similar intent with this PR, which was turned down:
#2079

Regardless, I would like to make a point about a statement you have made:
"Alarms won't come through if you set the tristate sound/vibrate/no sound button in the pull down menu to no sound".

That would be a serious shortcoming of an app that is meant to be useable as a medical app. even if not officially.
That's why we have volume profiles.
If you choose an appropriate volume profile, the alerts that respect volume profile will come through regardless of what you do to your volume.

Unfortunately, we have a few alerts that do not respect the volume profile, as summarized here: #1762.
In my opinion, missed reading, forecast low and persistent high alerts should also respect the volume profiles.

@Navid200
Copy link
Collaborator

Navid200 commented Apr 23, 2023

Just to emphasize, this is not a matter of convenience. It is in fact a matter of safely. Please let me give an example.

A parent and child are sleep. The parent's xDrip stops receiving readings. Previously, the parent was listening to a message on the phone that happened to be very loud. So, the parent lowered the volume on their phone and forgot to raise it back up.
Now, the parent's missed reading alert does not wake her up because the missed reading alert does not respect volume profiles. So, it is not loud enough to wake up the parent.

The parent wakes up in the morning and finds out that she has had no readings following her child for the past 6 hours!
I do not continue the story. you can imagine ...

@fwolter
Copy link
Contributor Author

fwolter commented Apr 23, 2023

Thanks for pointing me to the PR. I didn't search the closed PRs before filing this. I think the wording of the glucose alerts should be something like "Override silent mode and DND" and the Other alert setting should only referring to DND, because it won't override a volume of 0.

@jamorham wrote "xDrip doesn't override DND mode" here #2079 (comment). The HEAD version I tested overrides DND in Other alerts, but not volume 0. The glucose alerts override volume 0 and DND.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants