Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast start time from transmitter for G6 as well #3436

Merged
merged 4 commits into from May 12, 2024

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Apr 22, 2024

We changed the broadcasted start time for G7 to what G7 reports instead of the xDrip's local start time.
So far, we have had positive feedback from users and no complaints.

However, we now have one similar complaint about G6.

This PR does the exact same thing for Firefly G6 as well.

@Navid200
Copy link
Collaborator Author

It may seem there is redundancy with 3 new variables.
My concern was if we are using G6 and everything is working and then, we change the transmitter ID to that of a G7, Until we establish connectivity to G7, we are using G7 and we have had connectivity to G6. I didn't want this to result in making any broadcast.

That's why there is a variable that is set only if we are using G6 and we are connected to G6.
And there is a variable that is set if we are using G7 and we are connected to G7.

@Navid200 Navid200 requested a review from jamorham May 10, 2024 19:43
Copy link
Collaborator

@jamorham jamorham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining your design here and inline intention comments

@jamorham jamorham merged commit aaadf2d into NightscoutFoundation:master May 12, 2024
1 check passed
@Navid200 Navid200 deleted the Navid_2024_04_22 branch May 12, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants