Skip to content

Commit

Permalink
Make sure /dev/pts/ptmx is world-writable
Browse files Browse the repository at this point in the history
While running Python 3’s test suite, we noticed that on some systems
/dev/pts/ptmx is created with permissions 0 (that’s the case with my
Nixpkgs-originating 3.0.43 kernel, but someone with a Debian-originating
3.10-3 reported not having this problem.)

There’s still the problem that people without
CONFIG_DEVPTS_MULTIPLE_INSTANCES=y are screwed (as noted in build.cc),
but I don’t see how we could work around it.
  • Loading branch information
civodul authored and edolstra committed Apr 3, 2014
1 parent ac6ceea commit e7720aa
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/libstore/build.cc
Expand Up @@ -2086,6 +2086,10 @@ void DerivationGoal::initChild()
if (mount("none", (chrootRootDir + "/dev/pts").c_str(), "devpts", 0, "newinstance,mode=0620") == -1)
throw SysError("mounting /dev/pts");
createSymlink("/dev/pts/ptmx", chrootRootDir + "/dev/ptmx");

/* Make sure /dev/pts/ptmx is world-writable. With some
Linux versions, it is created with permissions 0. */
chmod_(chrootRootDir + "/dev/pts/ptmx", 0666);
}

/* Do the chroot(). Below we do a chdir() to the
Expand Down

0 comments on commit e7720aa

Please sign in to comment.