Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp tests #13

Open
Kawacrepe opened this issue Aug 13, 2022 · 5 comments
Open

Revamp tests #13

Kawacrepe opened this issue Aug 13, 2022 · 5 comments
Assignees
Labels
good first issue Good for newcomers
Projects

Comments

@Kawacrepe
Copy link
Member

Kawacrepe commented Aug 13, 2022

Our tests must be refacto, we must execute temp.js to create the nsecure-result.json which will be analyzed by the package.

We want to remove this file and include the step in our tests.

The second improvement consist in what Rossbob told me in another PR


I would have added some tests over rewriting it :

  • one without any options (flags & domainInformations)
  • one with flags
  • one with domainInformations

but it may be overkill

Originally posted by @Rossb0b in #12 (review)

@Kawacrepe Kawacrepe added the good first issue Good for newcomers label Aug 13, 2022
@Kawacrepe Kawacrepe reopened this Jan 19, 2023
@fraxken fraxken added this to Backlog in Roadmap Feb 24, 2023
@fabnguess fabnguess self-assigned this Aug 23, 2023
@fabnguess
Copy link
Contributor

@Kawacrepe can I take this issue?

@Kawacrepe
Copy link
Member Author

Yes, feel free to ping me if some additionnals informations are needed :)

@fabnguess
Copy link
Contributor

@Kawacrepe Yes, I want to make sure I understood the task correctly. This is effectively removing the temp.js file after carefully transposing its logic into a unit test. In conclusion, should we also implement Rossbob's recommendations

@Kawacrepe
Copy link
Member Author

Exactly, we should look at the rossbob recommendations :)

@fraxken
Copy link
Member

fraxken commented Sep 3, 2023

Going to rework them

@fraxken fraxken assigned fraxken and unassigned fabnguess Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Roadmap
Backlog
Development

No branches or pull requests

3 participants