Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore add domain check informations #12

Merged
merged 4 commits into from
Aug 13, 2022
Merged

Chore add domain check informations #12

merged 4 commits into from
Aug 13, 2022

Conversation

Kawacrepe
Copy link
Member

No description provided.

@Kawacrepe Kawacrepe marked this pull request as ready for review August 7, 2022 21:20
@Kawacrepe Kawacrepe requested a review from Rossb0b August 9, 2022 11:30
Rossb0b
Rossb0b reviewed Aug 9, 2022
View reviewed changes
Copy link

@Rossb0b Rossb0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have added some tests over rewriting it :

  • one without any options (flags & domainInformations)
  • one with flags
  • one with domainInformations

but it may be overkill

src/index.d.ts Outdated Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/index.d.ts Outdated Show resolved Hide resolved
@Kawacrepe Kawacrepe mentioned this pull request Aug 13, 2022
Open
@Kawacrepe Kawacrepe merged commit 5b2667a into main Aug 13, 2022
@fraxken fraxken deleted the chore--add-domain-check-informations branch December 20, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rossb0b Rossb0b Rossb0b left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kawacrepe @Rossb0b