[14.0] DES and EMEBI : update, improve and simplify #383
Conversation
l10n_fr_intrastat_product: - adapt to the very big changes I made in intrastat_product - DEB -> EMEBI - remove intrastat_fiscal_representative_id on res.partner - add a default intrastat transaction for B2C - filter intrastat_transaction_id on invoice form depending on move_type l10n_fr_intrastat_service: - auto-generate XML export upon confirmation to harmonize ergonomy with intrastat product - auto-delete XML upon back2draft - add confirmation pop-up when going back to draft - fix bug on total amount and number of lines when removing all lines - adapt for the fact that EU B2C fiscal positions now have intrastat=True
|
One important note: don't try to upgrade from previous version with existing data, it won't work ! Writing migration scripts will be a big task... but I guess we'll have to do it one day. |
|
hi @alexis-via. thanks for this huge contribution.
Not sure to understand. Did you plan to merge this PR before providing migration scripts ? Or this PR will stay opened ? |
|
@legalsylvain As explained on the underlying PR on OCA/intrastat-extrastat, I don't think the underlying PR will be merged. Maybe I will have some remarks that will lead to more changes in the datamodel, so I'd better wait for some first feedback before working on the migration script to avoid double work. Anyway, I'll have to write migration script to migrate my own customers, so I'll have to write them one day, and it will be a big work (and I'm not an expert in this field, so it takes me quite some time for me). But I wanted to publish this PR now, to get some feedback on the changes I propose and also to allow new installations to have a working version for DEB/EMEBI (the previous version was broken following a big Brexit PR that was over-complex OCA/intrastat-extrastat#163) |
|
Thanks a lot for your explanation. perfectly clear. |
alexis-via
changed the title
auto-reformatting
Set company_id to False on intrastat.transaction
Code cleanup.
_generate_xml() : Don't raise if company_id.fr_intrastat_accreditation is not set, to avoid blocking draft->done
| elif move_type in ("out_invoice", "out_refund"): | ||
| so_line = self.env["sale.order.line"].search( | ||
| [("invoice_lines", "in", inv_line.id)], limit=1 | ||
| ) | ||
| if so_line: | ||
| so = so_line.order_id | ||
| dpt = so.warehouse_id.get_fr_department() | ||
| dpt = so.warehouse_id._get_fr_department() |
There was a problem hiding this comment.
le champ warehouse_id est présent sur les so_lines
dpt = so_line.warehouse_id._get_fr_department()
j'ai un client qui fait du multi entrepot par commande.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
alexis-via
added
no stale
l10n_fr_intrastat_product (EMEBI):
l10n_fr_intrastat_service (DES):
Depends on PR OCA/intrastat-extrastat#198