[16.0][ADD] l10n_fr_department_product_origin #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legalsylvain
commented
Jan 12, 2024
| @@ -0,0 +1 @@ | |||
| git+https://github.com/OCA/product-attribute@refs/pull/1389/head#subdirectory=setup/product_origin | |||
There was a problem hiding this comment.
Hi @sbidoul.
Question : once setup folder has been removed, replaced by toml file, what is the correct syntax to write such dependency in the futur ?
thanks !
There was a problem hiding this comment.
@legalsylvain subdirectory is the directory where the python project is. The python project is where the setup.py or pyproject.toml is. So, just replace setup/product-origin with product_origin.
There was a problem hiding this comment.
Thanks ! very clear.
legalsylvain
force-pushed
the
16.0-ADD-l10n_fr_department_product_origin
branch
from
1fd39cd
to
4c27164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the pending PR : OCA/product-attribute#1389
(+ changes done in acsone/product-attribute#8)
Description
This module extends the functionality of Product Origin module to add french department on products.
CC : @quentinDupont, @alexis-via, @acsonefho