Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] dotfiles update needs manual intervention #545

Merged
merged 5 commits into from
May 24, 2024

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented May 1, 2024

Dear maintainer,

After updating the dotfiles, pre-commit run -a
fails in a manner that cannot be resolved automatically.

Can you please have a look, fix and merge?

Thanks,

@legalsylvain
Copy link
Contributor

Hi @sbidoul.

I don't understand why the errors was not present before ?

 account_banking_fr_lcr/models/account_payment_order.py:119:89: E501 Line too long (107 > 88)
l10n_fr_chorus_account/models/account_move.py:86:89: E501 Line too long (121 > 88)

rule about line length is not new at all ?

Anyway : @alexis-via : could you fix your modules ?
thanks.

@pedrobaeza
Copy link
Member

The line length rule was forgotten on the initial new ruff linter template, that was used to initialize 17.0 branches, but when it was later added, repos were not updated with it, so the problem grew.

@dreispt
Copy link
Sponsor Member

dreispt commented May 24, 2024

Done!

@dreispt dreispt requested a review from alexis-via May 24, 2024 11:00
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dreispt !

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-545-by-legalsylvain-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 24, 2024
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name l10n-france --branch 17.0 --addons-dir /tmp/tmpzbsxsauv --commit failed with output:

/tmp/tmpzbsxsauv/l10n_fr_das2/README.rst:: (ERROR/3) Anonymous hyperlink mismatch: 1 references but 0 targets.
See "backrefs" attribute for IDs.
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
    load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/ocamt/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 422, in publish_file
    output, publisher = publish_programmatically(
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 722, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 236, in publish
    self.apply_transforms()
  File "/ocamt/lib/python3.8/site-packages/docutils/core.py", line 216, in apply_transforms
    self.document.transformer.apply_transforms()
  File "/ocamt/lib/python3.8/site-packages/docutils/transforms/__init__.py", line 182, in apply_transforms
    transform.apply(**kwargs)
  File "/ocamt/lib/python3.8/site-packages/docutils/transforms/references.py", line 125, in apply
    msg = self.document.reporter.error(
  File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 231, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
  File "/ocamt/lib/python3.8/site-packages/docutils/utils/__init__.py", line 197, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmpzbsxsauv/l10n_fr_das2/README.rst:: (ERROR/3) Anonymous hyperlink mismatch: 1 references but 0 targets.
See "backrefs" attribute for IDs.

@dreispt dreispt force-pushed the 17.0-ocabot-update-dotfiles branch from 85f5bbb to ce3029d Compare May 24, 2024 11:38
@dreispt
Copy link
Sponsor Member

dreispt commented May 24, 2024

Made a tentative fix.

@dreispt
Copy link
Sponsor Member

dreispt commented May 24, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-545-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9c5c920 into 17.0 May 24, 2024
11 checks passed
@OCA-git-bot OCA-git-bot deleted the 17.0-ocabot-update-dotfiles branch May 24, 2024 18:38
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d9daa4b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants