[16.0][ADD] product_category_usage_group #1590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bealdav
reviewed
Apr 19, 2024
| # Overload Section | ||
| @api.model_create_multi | ||
| def create(self, vals_list): | ||
| templates = super(ProductTemplate, self).create(vals_list) |
There was a problem hiding this comment.
Suggested change
| templates = super(ProductTemplate, self).create(vals_list) | |
| templates = super().create(vals_list) |
| return res | ||
|
|
||
| # Custom Section | ||
| def _check_usage_product_category(self, categ_id): |
There was a problem hiding this comment.
@quentinDupont Why not using a constraint instead ?
There was a problem hiding this comment.
great point 😆
There was a problem hiding this comment.
I change the code and it makes it simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module extends the functionality of the product module, to restrict usage
of product categories to users that belong to a given group.
Migration from 12.0 of our custom module that we try to share with the OCA now :)
Use case for us : restrict a category where account code is not set by default