Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][ADD][sale_covenant] v10 new module sale_covenant WIP #432

Closed
wants to merge 9 commits into from

Conversation

bealdav
Copy link
Member

@bealdav bealdav commented Mar 20, 2017

Allowing to define settings in Sale fields (default values, allowed values, etc) according settings on a new object Sale Covenant (contract).
Use this module to define specific use case to your market, i.e.:

  • specific market: department store,
  • deliver products with white mark
  • sale to several clients of the same market but invoice a unique partner

depends on OCA/server-tools#784

ping @sebastienbeau

This module add this object: sale.covenant

cov

==============

Define onchange rule here: you can reuse this object to drive pricelist choice

covenant

Now you can play onchange without to write any code.

sale


pricelist is set dynamically according to Covenant field and set to readonly via field_view_get()


  • implements onchange with selection field
  • add tests

@bealdav
Copy link
Member Author

bealdav commented Mar 20, 2017

What do you think of the use case ? ping @lasley @rvalyi

if not self.partner_id:
self.covenant_id = False,
else:
self.covenant_id = self.partner_id.covenant_id.id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here ,you affect and id to an object (self.covenant_id (object) = self.partner_id.covenant_id.id (id)) ? that must generate a bug, is not it?

@mourad-ehm
Copy link
Contributor

travis is failed because the partner_id is now required in sale_covenant (in covenant_data.xml).

@mourad-ehm
Copy link
Contributor

Hi @alexis-via , I would back port this module to v 8.0. Please, could you validate the last changes before I do it ?

@rafaelbn rafaelbn changed the title v10 module sale_covenant WIP [10.0][ADD][sale_covenant] v10 new module sale_covenant WIP May 30, 2017
@rafaelbn
Copy link
Member

Hi @bealdav , is this still a WIP? Let us know please. Thanks

@rafaelbn rafaelbn added this to the 10.0 milestone May 30, 2017
@bealdav
Copy link
Member Author

bealdav commented May 30, 2017

Testable as it but we currently refactor the v8 version of its dependency base_onchange_rule (data structure).
We can stay as wip here.

Please Rafael, express your opinion on these modules and the different use case you can imagine, thanks

@bealdav
Copy link
Member Author

bealdav commented Oct 25, 2017

Replaced by sale_agreement from contract repo

@bealdav bealdav closed this Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants