New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0][ADD][sale_covenant] v10 new module sale_covenant WIP #432
Conversation
81c8099
to
07c6ccd
Compare
sale_covenant/models/sale.py
Outdated
if not self.partner_id: | ||
self.covenant_id = False, | ||
else: | ||
self.covenant_id = self.partner_id.covenant_id.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here ,you affect and id to an object (self.covenant_id (object) = self.partner_id.covenant_id.id (id)) ? that must generate a bug, is not it?
travis is failed because the partner_id is now required in sale_covenant (in covenant_data.xml). |
Hi @alexis-via , I would back port this module to v 8.0. Please, could you validate the last changes before I do it ? |
Hi @bealdav , is this still a WIP? Let us know please. Thanks |
Testable as it but we currently refactor the v8 version of its dependency base_onchange_rule (data structure). Please Rafael, express your opinion on these modules and the different use case you can imagine, thanks |
Replaced by sale_agreement from contract repo |
Allowing to define settings in Sale fields (default values, allowed values, etc) according settings on a new object Sale Covenant (contract).
Use this module to define specific use case to your market, i.e.:
depends on OCA/server-tools#784
ping @sebastienbeau
This module add this object: sale.covenant
==============
Define onchange rule here: you can reuse this object to drive pricelist choice
Now you can play onchange without to write any code.
pricelist is set dynamically according to Covenant field and set to readonly via field_view_get()