[14.0][ADD] shopfloor_reception_ refund_return #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move declaration of is_shopfloor_created from shopfloor_reception to shopfloor
TDu
force-pushed
the
14-add-shopfloor_reception_refund_return
branch
from
75eb048
to
327340c
Compare
jbaudoux
reviewed
Mar 22, 2024
| @@ -22,6 +22,7 @@ class StockPicking(models.Model): | |||
| compute="_compute_picking_info", | |||
| help="Technical field. Indicates number of move lines without package included.", | |||
| ) | |||
| is_shopfloor_created = fields.Boolean() | |||
There was a problem hiding this comment.
This definitely needs to move to shopfloor
However, you should update the scenario supporting allow_create_moves to use this flag when you cancel the operation:
- https://github.com/OCA/wms/blob/14.0/shopfloor/services/location_content_transfer.py#L303
- https://github.com/OCA/wms/blob/14.0/shopfloor/services/single_pack_transfer.py#L288
What is created by shopfloor should be canceled, otherwise it remains planned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to follow up on #669