[14.0][FIX] s_a_promise_release: Reset last_release_date on unrelease #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
approved these changes
Mar 22, 2024
|
@TDu Can you fwd port to 16.0 ? |
|
@TDu A little test should be welcome |
mmequignon
approved these changes
Apr 2, 2024
|
This PR has the |
jbaudoux
requested changes
Apr 29, 2024
Comment on lines
195
to
197
| self.filtered(lambda pick: pick.need_release).update( | ||
| {"last_release_date": False} | ||
| ) |
There was a problem hiding this comment.
This should be on the move otherwise if you unrelease the moves, this won't be triggered.
TDu
force-pushed
the
14-promise-release-fix-todo-counter
branch
from
6d59ec2
to
3c8b989
Compare
mt-software-de
approved these changes
May 15, 2024
|
@TDu Could you rebase ? |
When a transfer has been unreleased the `last_release_date` is not reset. This breaks the counters and the list of records (To Release, To Do) on the related channel.
TDu
force-pushed
the
14-promise-release-fix-todo-counter
branch
from
3c8b989
to
9420b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a transfer has been unreleased the
last_release_dateis not reset.This breaks the counters and the list of records (To Release, To Do) on the related channel.
Now with this change the field name/label is incoherent...