Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] stock_available_to_promise_release: Improve migration/init script to initialize 'release_policy' field with default values #888

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

rousseldenis
Copy link
Sponsor Contributor

The upgrade script should initialize the value with the sql default instead updating every existing record (maybe billions).

@rousseldenis rousseldenis force-pushed the 16.0-fix-release_policy-dro branch 3 times, most recently from 683bc99 to 938822a Compare April 10, 2024 11:52
…pt to initialize field with default values

The upgrade script should initialize the value with the sql default instead updating every existing
record (maybe billions).
@rousseldenis
Copy link
Sponsor Contributor Author

@jbaudoux @mt-software-de

@rousseldenis rousseldenis added enhancement New feature or request needs review labels Apr 10, 2024
@rousseldenis rousseldenis added this to the 16.0 milestone Apr 10, 2024
@rousseldenis rousseldenis changed the title [IMP] stock_available_to_promise_release: Improve migration/init script to initialize field with default values [IMP] stock_available_to_promise_release: Improve migration/init script to initialize 'release_policy' field with default values Apr 10, 2024
@rousseldenis
Copy link
Sponsor Contributor Author

This is the magic:

image

@mt-software-de
Copy link
Contributor

Many thanks yes this was missing.
Why did not set the release_policy as it is done here?

@rousseldenis
Copy link
Sponsor Contributor Author

Many thanks yes this was missing. Why did not set the release_policy as it is done here?

Here, I initialize the field with the default value, so, it should be done in pre script.

I've put it also in pre-init as the module can be installed on huge database too

@mt-software-de
Copy link
Contributor

Many thanks yes this was missing. Why did not set the release_policy as it is done here?

Here, I initialize the field with the default value, so, it should be done in pre script.

I've put it also in pre-init as the module can be installed on huge database too

Many thanks yes this was missing. Why did not set the release_policy as it is done here?

Here, I initialize the field with the default value, so, it should be done in pre script.

I've put it also in pre-init as the module can be installed on huge database too

Yes i have seen this, but why we don't remove the post_migration
and moving the post_migration part into the new init method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants