[16.0][IMP] stock_available_to_promise_release: Improves perfs #894
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field 'ordered_available_to_promise_qty' is a computed field without depends. In the implementation of the `_is_release_ready` we expect that this field is up to date. Prior to this change, the 'ordered_available_to_promise_qty' was invalidated into the '_is_release_ready' method to ensure consistency. Unfortunately, since the '_is_release_ready' method is designed to work a a single record, when it was called from `_compute_release_ready` methods on a large recordset, this way of doing has as side effect to break the batch computation of the 'ordered_available_to_promise_qty' since the value was invalidated one at a time for each record. To restore the batch computation of the 'ordered_available_to_promise_qty', the cache invalidation is now done into the caller methods for the whole recordset
lmignon
force-pushed
the
16.0-stock_available_to_promise_release-perf
branch
from
46f79f7
to
28842bf
Compare
sebalix
approved these changes
May 3, 2024
jbaudoux
approved these changes
Jun 4, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
OCA-git-bot
added a commit
that referenced
this pull request
Jun 4, 2024
|
It looks like something changed on |
|
Congratulations, your PR was merged at 616ae61. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field 'ordered_available_to_promise_qty' is a computed field without depends. In the implementation of the
_is_release_readywe expect that this field is up to date. Prior to this change, the 'ordered_available_to_promise_qty' was invalidated into the '_is_release_ready' method to ensure consistency. Unfortunately, since the '_is_release_ready' method is designed to work a a single record, when it was called from_compute_release_readymethods on a large recordset, this way of doing has as side effect to break the batch computation of the 'ordered_available_to_promise_qty' since the value was invalidated one at a time for each record. To restore the batch computation of the 'ordered_available_to_promise_qty', the cache invalidation is now done into the caller methods for the whole recordset