Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] sale_stock_available_to_promise_release add ir.config_pa… #896

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

victorvermot
Copy link

@victorvermot victorvermot commented Apr 30, 2024

Add parameter to make the column Available on SO reports invisible

Results

  • Setting enabled
    OCAAB
  • With setting activated
    OCAAB1
  • Setting disabled
    OCAAB2

@victorvermot victorvermot force-pushed the 16.0-sale_stock_available_to_promise_release branch from 75b8eb0 to ef41a00 Compare April 30, 2024 08:30
@victorvermot victorvermot marked this pull request as ready for review April 30, 2024 08:30
@victorvermot victorvermot force-pushed the 16.0-sale_stock_available_to_promise_release branch 3 times, most recently from 8ec116f to 25565b2 Compare May 1, 2024 09:40
@victorvermot victorvermot force-pushed the 16.0-sale_stock_available_to_promise_release branch from 25565b2 to ef12db2 Compare May 1, 2024 09:48
@victorvermot victorvermot force-pushed the 16.0-sale_stock_available_to_promise_release branch from ef12db2 to fbf0c70 Compare May 1, 2024 11:48
@victorvermot victorvermot force-pushed the 16.0-sale_stock_available_to_promise_release branch 2 times, most recently from db179ca to 75688f1 Compare May 15, 2024 09:22
@victorvermot victorvermot requested a review from sebalix May 15, 2024 11:10
@victorvermot victorvermot force-pushed the 16.0-sale_stock_available_to_promise_release branch from 75688f1 to cb6d778 Compare May 15, 2024 11:34
@victorvermot victorvermot force-pushed the 16.0-sale_stock_available_to_promise_release branch from cb6d778 to 7734638 Compare May 15, 2024 12:36
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖


stock_sale_report_display_is_available = fields.Boolean(
help="Show Available column in SO and quotation reports",
default=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be False by default ?

cc @sebalix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this PR the column was always displayed, we are only adding an option here to hide it, but by default we keep it displayed as before. No?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good then :)

@jbaudoux jbaudoux changed the title [16.0][ADD]: sale_stock_available_to_promise_release add ir.config_pa… [16.0][IMP] sale_stock_available_to_promise_release add ir.config_pa… May 27, 2024
@jbaudoux
Copy link
Contributor

@victorvermot Can you drop [16.0][ADD]: from the commit message ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants