Observe the route prefix in RestierSwaggerProvider #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Before this commit When mapping a Restier route with a non empty route prefix, the generated swagger file does not include the route prefix in the `servers[0].url` property. ```csharp app.MapRestier(restier => restier.MapApiRoute<EntityFrameworkApi<MyDbContext>>(routeName: "RestierDefault", routePrefix: "api")); ``` ❌ The generated url is `http://localhost:5000`, making all requests from SwaggerUI fail with 404 errors. ## After this commit The route prefix is included in the generated swagger file in the `servers[0].url` property. ✅ The generated url is `http://localhost:5000/api/`, making SwaggerUI usable. Fixes OData#749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit
When mapping a Restier route with a non empty route prefix, the generated swagger file does not include the route prefix in the
servers[0].urlproperty.❌ The generated url is
http://localhost:5000, making all requests from SwaggerUI fail with 404 errors.After this commit
The route prefix is included in the generated swagger file in the
servers[0].urlproperty.✅ The generated url is
http://localhost:5000/api/, making SwaggerUI usable.Fixes #749