feat(cli): get latest dependencies versions from npm #77
Conversation
|
Couldn't find any way to get versions for multiple packages with one request to npm APIs, and I couldn't find any alternative that supports it as well... I followed the instructions here for the metadata request: |
| @@ -9,7 +8,7 @@ const dirname = process | |||
| .pop() as string; | |||
|
|
|||
| export default () => | |||
| execa('npm', ['run', 'plop', 'component', process.cwd(), uppercamelcase(dirname)], { | |||
| execa('npm', ['run', 'plop', 'component', process.cwd(), dirname], { | |||
There was a problem hiding this comment.
Should we do lower tho?
There was a problem hiding this comment.
not sure... at this point it just shows the name of the folder... I'm running lower in the name property in package.json file... I'm considering whether or not we should auto kebab-case it...?
There was a problem hiding this comment.
Nah I think it's fine to leave it be
| import fetch from 'node-fetch'; | ||
|
|
||
| const getDependencyMetadata = async (name: string) => | ||
| fetch(`https://registry.npmjs.org/${name}`, { |
client/cli/plop/utils.ts
Outdated
| }).then(r => r.json()); | ||
|
|
||
| export const getVersionsForDependencies = async (deps: string[]) => { | ||
| return (await Promise.all(deps.map(d => getDependencyMetadata(d)))).reduce( |
client/cli/plop/utils.ts
Outdated
|
|
||
| export const getVersionsForDependencies = async (deps: string[]) => { | ||
| return (await Promise.all(deps.map(d => getDependencyMetadata(d)))).reduce( | ||
| (soFar: Record<string, string>, current: any) => ({ |
|
matter of seconds on WiFi... |
eladav
force-pushed
the
feat-get-latest-deps-versions
branch
from
f4d8e96
to
f3714df
Compare
client/cli/plop/component/index.ts
Outdated
| const { dependencies, devDependencies, peerDependencies } = JSON.parse( | ||
| plop.renderString(readFileSync(`./plop/component/${data.framework}/package.hbs`, 'utf-8'), data) | ||
| ); | ||
| return await getVersionsForDependencies( |
There was a problem hiding this comment.
I don't think we need async await here
| }).then(r => r.json()); | ||
|
|
||
| export const getVersionsForDependencies = async (deps: string[]) => | ||
| (await Promise.all(deps.map(d => getDependencyMetadata(d)))).reduce( |
There was a problem hiding this comment.
Also here do we have to use async await?
Returning promise is enough imo
There was a problem hiding this comment.
So I can ‘reduce’ on the promise.all result to a name:version object
* Read package file and get versions for required dependencies * Lowercase package name
eladav
force-pushed
the
feat-get-latest-deps-versions
branch
from
f3714df
to
c1c4729
Compare
solves When initializing a new component dependencies versions should be up-to-date #71