Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSSQLSpatial: Don't truncate string values #844

Merged
merged 1 commit into from Aug 13, 2018
Merged

MSSQLSpatial: Don't truncate string values #844

merged 1 commit into from Aug 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 12, 2018

What does this PR do?

Modify OGRMSSQLSpatialTableLayer::AppendFieldValue() to shorten, on UNIX and other systems where the size of wchar_t is greater than two bytes, the length of each character in a wide-character string before passing it on to the ODBC driver so a string field's value is not truncated.

What are related issues/pull requests?

Fixes #843.

Tasklist

  • Add test case(s)
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

Environment

Provide environment details, if relevant:

  • OS: Ubuntu 16.04.5 64-bit (via Windows Subsystem for Linux on Windows 10)
  • Compiler: g++ 5.4.0

On UNIX and other systems where the size of "wchar_t" is greater than two
bytes, shorten the length of each charater in a wide-character string before
passing it to the ODBC driver so the string is not truncated.
@rouault rouault merged commit 6b23622 into OSGeo:master Aug 13, 2018
@ghost ghost deleted the 843-mssqlspatial-dont-truncate-string-values branch August 13, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant