Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: Reduce minimum browser window width to 480px #698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marex
Copy link

@marex marex commented Mar 1, 2023

The TST043015CNHX panel is a 480x272 panel. Chromium browser limits the minimum window width to 500px since commits:

6b0ecc1e4532c ("Set lower bound on contents pane size.")

580d6900dc7fc ("In tab dragging, the window size should be larger than its minimum size.")

To make chromium browser usable on those tiny panels as well, reduce the minimum window width to 480px. The upstreaming of this change is in progress.

The TST043015CNHX panel is a 480x272 panel. Chromium browser limits the
minimum window width to 500px since commits:

6b0ecc1e4532c ("Set lower bound on contents pane size.")
580d6900dc7fc ("In tab dragging, the window size should be larger than its minimum size.")

To make chromium browser usable on those tiny panels as well, reduce
the minimum window width to 480px. The upstreaming of this change is
in progress.

Signed-off-by: Marek Vasut <marex@denx.de>
@rakuco
Copy link
Collaborator

rakuco commented Mar 1, 2023

The upstreaming of this change is in progress.

Is there a CL in Gerrit or an upstream bug report you can refer to? I'm weary of taking this patch in without more information, as the new size also looks somewhat arbitrary from a meta-chromium perspective.

@marex
Copy link
Author

marex commented Mar 1, 2023

The upstreaming of this change is in progress.

Is there a CL in Gerrit or an upstream bug report you can refer to? I'm weary of taking this patch in without more information, as the new size also looks somewhat arbitrary from a meta-chromium perspective.

@rakuco I sent the patch to the authors of the aforementioned two commits via email as the chromium contribution guidelines are difficult for such a one-liner . I cannot tell whether they created a crbug from that, sorry, but this one https://bugs.chromium.org/p/chromium/issues/detail?id=875197 is very much the same issue (and probably any other crbug which mentions "500px" in some width context)

@otavio otavio requested a review from rakuco March 8, 2023 12:54
@otavio
Copy link
Member

otavio commented Mar 8, 2023

I support the addition of a workaround for this, but we need a long-term vision to remove the workaround. @rakuco, can you fix this upstream?

@marex
Copy link
Author

marex commented Oct 10, 2023

@otavio @rakuco has there been any progress ? The patch still applies to latest chromium version too.

@otavio
Copy link
Member

otavio commented Oct 10, 2023

I support adding this patch. @rakuco ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants