chromium: Update to 123.0.6312.122 #806
Conversation
|
@rjanani-p as always, testing would be greatly appreciated! Please note that the build for nanbield will not work, you only need to test scarthgap and master. |
|
Also, #792 (comment) applies here as well: you'll probably need #808 as well to build master. |
MaxIhlenfeldt
force-pushed
the
123.0.6312.122
branch
from
b6e64a2
to
e490f4a
Compare
|
Rebased this PR to include all the recently merged PRs. This should fix all build issues that are unrelated to this update. @rjanani-p please let me know if there's anything else blocking you from testing this PR. |
sure @MaxIhlenfeldt , I will start testing and update the test results. Thank you. |
@MaxIhlenfeldt , I have completed the testing for Poky master with latest changes, sharing the results for reference: 1.For chromium-x11 & qemux86-64 target: compiled successfully without build issues, able to check chromium version using qemux86-64 emulator 2.For chromium-x11 & qemuarm target: compiled successfully without build issues, to check chromium version using qemuarm emulator unable to check it due to curser / mouse is not working properly while operating with chromium browser 3.For chromium-x11 & qemuarm64 target: compiled successfully without build issues, able to check chromium version using qemuarm64 emulator 4.For chromium-x11 & raspberrypi4-64 target: compiled successfully without build issues, didn't check with hardware due to hardware unavailability. I will start testing for Poky scarthgap. |
|
@MaxIhlenfeldt , getting below build issue for poky_scarthgap branch for qemux86-64 target, could you please check once . [237/58295] python3 ../../third_party/blink/renderer/build/scripts/run_with_pythonpath.py -I ../../third_party/blink/renderer/build/scripts -I ../../third_party -I ../../third_party/pyjson5/src -I ../../tools ../../third_party/blink/renderer/build/scripts/core/css/make_css_property_names.py ../../third_party/blink/renderer/core/css/css_properties.json5 ../../third_party/blink/renderer/core/css/computed_style_field_aliases.json5 ../../third_party/blink/renderer/platform/runtime_enabled_features.json5 --output_dir gen/third_party/blink/renderer/core/css --gperf gperf line 149 contains, below code snippet: $ builds_chromium/build_poky_scarthgap_chrom_123_ver/tmp/work/core2-64-poky-linux/chromium-x11/123.0.6312.122/temp/run.do_compile.1636856, line 153 Please find build log error: Node.js v20.12.2 |
Hm, this seems to be the same error you described in #803 (comment). If I understand #803 (comment) correctly, that time the issue didn't happen any more in a clean build. Can you please try doing a clean build and see if it fixes the issue this time as well? |
@MaxIhlenfeldt ,I have tried with clean build, but getting same issue. Did you observe same issue during you are testing. |
@rjanani-p I haven't seen this specific error message in any local build I've done. As the error is related to Node's internationalization support, please provide the following information that hopefully helps with finding its cause. (reference: https://nodejs.org/api/intl.html) Node build setupThe default for the nodejs recipe is to build Node with the And to be completely sure, please run do_configure() {
GYP_DEFINES="${GYP_DEFINES}" export GYP_DEFINES
# $TARGET_ARCH settings don't match --dest-cpu settings
python3 configure.py --verbose --prefix=/home/chromium/yocto-chromium/builds/chromium-x11-qemux86-64-scarthgap/tmp-glibc/work/x86_64-linux/nodejs-native/20.12.2/recipe-sysroot-native/usr \
--shared-openssl \
--dest-cpu="x64" \
--dest-os=linux \
--libdir=lib \
--no-cross-compiling \
\
--shared-cares --shared-brotli --with-intl=system-icu --shared-zlib
}
cd '/home/chromium/yocto-chromium/builds/chromium-x11-qemux86-64-scarthgap/tmp-glibc/work/x86_64-linux/nodejs-native/20.12.2/node-v20.12.2'
do_configureChecking ICU support at runtimePlease run const hasICU = typeof process.versions.icu === 'string';
console.log(`hasICU: ${hasICU} version=${process.versions.icu}`);
const hasFullICU = (() => {
try {
const january = new Date(9e8);
const spanish = new Intl.DateTimeFormat('es', { month: 'long' });
return spanish.format(january) === 'enero';
} catch (err) {
return false;
}
})();
console.log(`hasFullICU: ${hasFullICU}`);
const cmp = 'foo'.localeCompare('bar', 'en');
console.log(`cmp: ${cmp}`);and then run Running btest402As above, please start a |
@MaxIhlenfeldt , I have followed the steps which you are shared and executed the commands. For last 2 commands getting below issue Let me free up the memory in my workspace and let me start the clean build from my side. Could you please share your inputs to resolve the issue. Thank you!. |
|
@rjanani-p thanks! Please also re-run the "Checking ICU support at runtime" and "Running btest402" after freeing up memory and paste the results here. |
@MaxIhlenfeldt , I have tried again after free up the memory in workspace and tried with clean build but getting same issue. Do I need to set up any config for poky scarthgap? attaching build configuration for reference: Checking ICU support at runtime: <--- Last few GCs ---> <--- JS stacktrace ---> FATAL ERROR: DateTimePatternGeneratorCache::CreateGenerator Allocation failed - process out of memory 1: 0x560ad9fa344f node::OOMErrorHandler(char const*, v8::OOMDetails const&) [third_party/node/linux/node-linux-x64/bin/node] Running btest402: $third_party/node/linux/node-linux-x64/bin/node btest402.js
<--- Last few GCs ---> <--- JS stacktrace ---> FATAL ERROR: DateTimePatternGeneratorCache::CreateGenerator Allocation failed - process out of memory 1: 0x5654425a344f node::OOMErrorHandler(char const*, v8::OOMDetails const&) [third_party/node/linux/node-linux-x64/bin/node] |
|
@rjanani-p I don't think you need any special setup. What's the output of |
|
@MaxIhlenfeldt - this v123 pull request is building and working with the Texas Instruments Scarthgap yocto and GPU acceleration is functional across PowerVR platforms (non-SGX) using chromium-ozone-wayland. With version 122 and 123 I have had to switch from --use-gl=egl to --use-gl=angle for GPU accel to work correctly. I also have pulled in this upstream chromium GPU patch: |
@MaxIhlenfeldt , please find the free -k command results |
|
@darren-etheridge thanks! Should you notice that the mentioned patch is needed in m123 after all, feel free to open an issue and I can add it as a backport. |
|
@rjanani-p hm, the only thing standing out to me is that your swap space is completely full even though there's enough memory still available. Other than "have you tried turning it off and on again" I'm out of ideas. I do think however that this "out of memory" issue could well be the root cause of Node's "ICU error" message - V8 calls out to ICU, and if that fails to allocate V8 will error out with exactly the message Node is displaying. Given all this and the fact that m125 is already shipping to Stable, I'd propose merging this and investigating the Node error separately, so I can start working on the m124 update. @rakuco wdyt? |
Sounds good to me! |
Fixes OSSystems#796. Note that this PR drops support for Nanbield (which is scheduled to reach its EOL this month anyway), see the discussion at OSSystems#796 for why. Release notes: https://chromereleases.googleblog.com/2024/03/stable-channel-update-for-desktop_19.html https://chromereleases.googleblog.com/2024/03/stable-channel-update-for-desktop_26.html https://chromereleases.googleblog.com/2024/04/stable-channel-update-for-desktop.html https://chromereleases.googleblog.com/2024/04/stable-channel-update-for-desktop_10.html Build and patch changes: ------------------------ Drop one backported patch that is included upstream now. Rebase remaining patches. License changes: ---------------- Added licenses: * third_party/android_deps/libs/com_google_android_gms_play_services_tflite_impl/LICENSE, third_party/android_deps/libs/com_google_android_gms_play_services_tflite_java/LICENSE, third_party/android_deps/libs/org_tensorflow_tensorflow_lite_api/LICENSE - https://chromium-review.googlesource.com/c/chromium/src/+/5288046 * third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_android_extensions_runtime/LICENSE, third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_parcelize_runtime/LICENSE - https://chromium-review.googlesource.com/c/chromium/src/+/5260026 * third_party/android_deps/libs/org_jetbrains_kotlinx_atomicfu_jvm/LICENSE - https://chromium-review.googlesource.com/c/chromium/src/+/5237443 Removed licenses: * third_party/catapult/third_party/Paste/docs/license.txt - https://chromium-review.googlesource.com/c/catapult/+/5288589 * third_party/screen-ai/LICENSE - Not sure why. Updated licenses: * third_party/android_deps/libs/com_google_android_gms_play_services_base/LICENSE - https://chromium-review.googlesource.com/c/chromium/src/+/5288046 Test-built (big thanks to @rjanani-p): -------------------------------------- * chromium-ozone-wayland: - master, clang, MACHINE=qemux86-64 - scarthgap, clang, MACHINE=qemuarm64 * chromium-x11: - master, clang, MACHINE=qemuarm, qemuarm64, qemux86-64, raspberrypi4-64 Signed-off-by: Max Ihlenfeldt <max@igalia.com>
MaxIhlenfeldt
force-pushed
the
123.0.6312.122
branch
from
e490f4a
to
ffbe405
Compare
Fixes #796.
Note that this PR drops support for Nanbield (which is scheduled to reach its EOL this month anyway), see the discussion at #796 for why.
Release notes:
https://chromereleases.googleblog.com/2024/03/stable-channel-update-for-desktop_19.html
https://chromereleases.googleblog.com/2024/03/stable-channel-update-for-desktop_26.html
https://chromereleases.googleblog.com/2024/04/stable-channel-update-for-desktop.html
https://chromereleases.googleblog.com/2024/04/stable-channel-update-for-desktop_10.html
Build and patch changes:
Drop one backported patch that is included upstream now.
Rebase remaining patches.
License changes:
Added licenses:
Removed licenses:
Updated licenses:
Test-built (big thanks to @rjanani-p):