Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PrintJobHistoryAPI.py to fix GET of thumbnails that broke arou… #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update PrintJobHistoryAPI.py to fix GET of thumbnails that broke arou… #216

wants to merge 1 commit into from

Conversation

dojohnso
Copy link

…nd Octoprint 1.9 timeframe

removed outdated cache_timeout and replaced with max_age, set to 1 day (86400 seconds) but whatever makes sense is good there if you wanted to change it.

@dojohnso
Update PrintJobHistoryAPI.py to fix GET of thumbnails that broke arou…
1d86931 
…nd Octoprint 1.9 timeframe

removed outdated cache_timeout and replaced with max_age, set to 1 day (86400 seconds) but whatever makes sense is good there if you wanted to change it.
@dojohnso dojohnso mentioned this pull request May 25, 2023
Open
@HarikrishnanBalagopal
Copy link

why isn't it merged? it got approved.
Is this plugin still maintained?

@dojohnso
Copy link
Author

dojohnso commented Aug 2, 2023

why isn't it merged? it got approved. Is this plugin still maintained?

Doesn't appear to be. I'll look into reporting it and possibly taking it over

@dojohnso dojohnso mentioned this pull request Aug 2, 2023
Closed
@dojohnso
Copy link
Author

dojohnso commented Aug 2, 2023

why isn't it merged? it got approved. Is this plugin still maintained?

I filed an Abandoned bug and am told that @OllisGit is back to plugin dev so hopefully this will see some activity soon.

@ROunofF
Copy link

ROunofF commented Sep 16, 2023

I applied manually this patch and it fixed it! Good job @dojohnso

rob4226 added a commit to rob4226/OctoPrint-PrintJobHistory-ExternalDatabase that referenced this pull request Sep 17, 2023
@rob4226
fix: apply pr OllisGit#216 to fix slicer images
97a2572 
OllisGit#216 (comment)
It wasn't merged in yet so applying it manually.
rob4226 added a commit to rob4226/OctoPrint-PrintJobHistory-ExternalDatabase that referenced this pull request Sep 18, 2023
@rob4226
fix: apply pr OllisGit#216 to fix slicer images
80a0cc9 
OllisGit#216 (comment)
It wasn't merged in yet so applying it manually.
@thijstriemstra
Copy link

Can this please be merged?

@dojohnso
Copy link
Author

anyone that comes here and sees this, if it hasn't been merged yet, please go comment on this ticket with OctoPrint to convince them this project is abandoned.

OctoPrint/plugins.octoprint.org#1222

/cc @thijstriemstra

@thijstriemstra
Copy link

anyone that comes here and sees this, if it hasn't been merged yet, please go comment on this ticket with OctoPrint to convince them this project is abandoned.

Any alternatives for this plugin exist?

@Filmman586
Copy link

Please get this fixed, it’s been way to long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

@fellipute fellipute fellipute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dojohnso @HarikrishnanBalagopal @ROunofF @thijstriemstra @Filmman586 @fellipute @HAndreasH